openai realtime: default create_response to True #1434
Conversation
🦋 Changeset detectedLatest commit: c09f1ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -143,7 +143,7 @@ class ServerVadOptions: | |||
| threshold: float | |||
| prefix_padding_ms: int | |||
| silence_duration_ms: int | |||
| create_response: bool | |||
There was a problem hiding this comment.
What's the reason behind this? we already have defalt servervad options here
There was a problem hiding this comment.
when this wasn't set.. it was breaking our examples that customize VAD options. in general we should strive to reduce breakage to user ccode
There was a problem hiding this comment.
In that case we should also set default values for other feilds too?
There was a problem hiding this comment.
IMO we should remove defaults from here and keep it directly in dataclass
No description provided.