Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt to STT options #1447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add prompt to STT options #1447

wants to merge 1 commit into from

Conversation

ShayneP
Copy link

@ShayneP ShayneP commented Feb 4, 2025

We should be able to set the prompt for STT providers to be give hints for transcriptions, this can help spelling.

@ShayneP ShayneP requested a review from theomonnom February 4, 2025 20:53
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: fc6969f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@davidzhao
Copy link
Member

wanna run ruff format . on this? otherwise it lgtm

) -> None:
self._opts.model = model or self._opts.model
self._opts.language = language or self._opts.language
if prompt is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update it back to None if a user wants to clear the previous prompt too.

@@ -104,6 +109,7 @@ def with_groq(
client: openai.AsyncClient | None = None,
language: str = "en",
detect_language: bool = False,
prompt: str = "Always spell 'Grok' as 'Groq'",
Copy link
Member

@davidzhao davidzhao Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this doesn't belong as a default prompt. it would be weird if someone uses it in a sentence, and see it misspelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants