Skip to content

Commit

Permalink
cli: Deprecate --cpu host
Browse files Browse the repository at this point in the history
While the shorthand saves a tiny bit of typing, it is confusing
to people coming from QEMU, where -cpu host is the equivalent
of our --cpu host-passthrough. It's better to stick with the
unambiguous names used by libvirt.

Besides, the GUI already uses "host-model" throughout, so
advocating its use in the CLI too increases the internal
consistency.

https://issues.redhat.com/browse/RHEL-40003

Signed-off-by: Andrea Bolognani <[email protected]>
  • Loading branch information
andreabolognani authored and phrdina committed Jun 11, 2024
1 parent 8b5f73e commit eee8d09
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions virtinst/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -2338,6 +2338,7 @@ def bandwidth_find_inst_cb(self, *args, **kwargs):

def set_model_cb(self, inst, val, virtarg):
if val == "host":
log.warning(_("CPU model=host is deprecated, use model=host-model"))
val = inst.SPECIAL_MODE_HOST_MODEL
if val == "none":
val = inst.SPECIAL_MODE_CLEAR
Expand Down

0 comments on commit eee8d09

Please sign in to comment.