[CIR][CIRGen][Builtin] Support __builtin_return_address #1046
+88
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghehg
changed the title
bcardosolopes
requested changes
Nov 4, 2024
ghehg
force-pushed
the
second
branch
2 times, most recently
from
1c5ea0b
to
e18d6a5
Compare
bcardosolopes
approved these changes
Nov 6, 2024
|
|
||
| def ReturnAddrOp : CIR_Op<"return_address"> { | ||
| let arguments = (ins UInt32:$level); | ||
| let summary = "call to `__builtin_return_address`"; |
There was a problem hiding this comment.
Summary should be a bit more generic, extracting from your full desc, one idea: The return address of the current function or of one of its callers.
There was a problem hiding this comment.
Make sense, just updated the summary
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test case is from Traditional Clang CodeGen test file