[CIR] Extend support for floating point attributes #572
Conversation
|
Upstream patch: llvm/llvm-project#90442 |
lanza
force-pushed
the
main
branch
2 times, most recently
from
c4db6d0
to
e197d4e
Compare
|
Nathan just did a rebase, can you please update? Sorry for the churn |
|
Rebased 🙏 |
|
Thanks for going the extra length to make sure this works! |
Merged upstream 🎉 |
|
@bcardosolopes - is there any planned rebase anytime soon? This PR is blocked by getting the upstream patch. Alternatively, I assume we can cherry-pick it here and there's a 95% chance that it will dissolve on the next rebase. Let me know what you prefer 🙏🏼 |
@lanza wdyt? |
|
I pushed a rebase just now. Should be good to go :p |
orbiri
force-pushed
the
orbiri/fp-parse
branch
from
d3d3988
to
2a65d71
Compare
orbiri
force-pushed
the
orbiri/fp-parse
branch
from
2a65d71
to
9c2c7ef
Compare
|
@bcardosolopes - I found some time this weekend to rebase and make this PR ready for merge :) |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
orbiri
force-pushed
the
orbiri/fp-parse
branch
from
9c2c7ef
to
8c45c7c
Compare
This commit extends the support for floating point attributes parsing by using the new `AsmParser::parseFloat(fltSemnatics, APFloat&)` interface. As a drive-by, this commit also harmonizes the cir.fp print/parse namespace usage, and adds the constraint of supporting only "CIRFPType"s for cir.fp in tablegen instead of verifying it manually in the parsing logic.
orbiri
force-pushed
the
orbiri/fp-parse
branch
from
8c45c7c
to
58cd2af
Compare
This commit extends the support for floating point attributes parsing by using
the new
AsmParser::parseFloat(fltSemnatics, APFloat&)interface.As a drive-by, this commit also harmonizes the cir.fp print/parse namespace
usage, and adds the constraint of supporting only "CIRFPType"s for cir.fp in
tablegen instead of verifying it manually in the parsing logic.
This commit is based on top of a to-be-upstreamed commit which extends the upstream MLIR float type parsing. Upstream parsing of float type has full capability only through parsing the Builtin Dialect's
FloatAttr. Thos commit exposes the same capabilities to downstream users.This PR should resolve (at least)
GCC-C-execute-ieee-fp-cmp-2andGCC-C-execute-ieee-fp-cmp-4, paving the way to otherGCC-C-execute-ieee-*tests passing from the SingleSource suite. It resolves #559 .