Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PS5][Driver] Restore whole-archive state when -fjmc #115181

Merged
merged 2 commits into from
Nov 6, 2024
+5 −4
Merged

[PS5][Driver] Restore whole-archive state when -fjmc #115181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2eec3d
[PS5][Driver] Restore whole-archive state when `-fjmc`
playstation-edd Nov 6, 2024
e8f4650
CHECK-LIB -> CHECK-JMC
playstation-edd Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/lib/Driver/ToolChains/PS4CPU.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,10 @@ void tools::PS5cpu::Linker::ConstructJob(Compilation &C, const JobAction &JA,
}

if (UseJMC) {
CmdArgs.push_back("--push-state");
CmdArgs.push_back("--whole-archive");
CmdArgs.push_back("-lSceJmc_nosubmission");
CmdArgs.push_back("--no-whole-archive");
CmdArgs.push_back("--pop-state");
}

if (Args.hasArg(options::OPT_fuse_ld_EQ)) {
Expand Down
2 changes: 1 addition & 1 deletion clang/test/Driver/ps5-linker.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
// CHECK: -plugin-opt=-enable-jmc-instrument

// Check the default library name.
// CHECK-LIB: "--whole-archive" "-lSceJmc_nosubmission" "--no-whole-archive"
// CHECK-LIB: "--push-state" "--whole-archive" "-lSceJmc_nosubmission" "--pop-state"

// Test the driver's control over the -fcrash-diagnostics-dir behavior with linker flags.

Expand Down
Loading