[TorchToLinalg]Lower torch.gcd to linalg and scf #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratislavSyrmia
force-pushed
the
lower_torch_aten_gcd_to_linalg_and_scf
branch
from
7673a8f
to
0815cd1
Compare
|
force push: added math::cttz instead of counting trailing zeros manually |
IanWood1
reviewed
Sep 30, 2024
projects/pt1/python/torch_mlir_e2e_test/test_suite/elementwise.py
Outdated
Show resolved
Hide resolved
Add verify() method to check if tensors are of integer type. Also check if tensors are of same shape, or if the second tensor is a single element tensor. Add e2e tests. Put them into onnx and stablehlo xfailed sets.
bratislavSyrmia
force-pushed
the
lower_torch_aten_gcd_to_linalg_and_scf
branch
from
0815cd1
to
53b1ec3
Compare
There was a problem hiding this comment.
Hi @bratislavSyrmia, I would like you to explore a non-loop path for this lowering, since these kind of lowerings usually causes issues in the downstream pipeline especially the code-generation part.
@vivekkhandelwal1 out of curiosity, do you have an algorithm/solution in mind? The best I could think of was to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add verify() method to check if tensors are of
integer type. Also check if tensors are of same shape, or if the second tensor is a single element tensor.
Add e2e tests. Put them into onnx and stablehlo
xfailed sets.