New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some typo and bug fix #35

Open

peacedog123 wants to merge 1 commit into lni:master from peacedog123:master

peacedog123 commented Aug 10, 2024

Fix inconsistency of flags in multigroup example
Fix NodeHost.Stop() called twice problem

In the README.md
The command has changed to ./example-multigroup -replicaid 1, so here change the code to make it consistent between code and README.md file.
When we input exit in the console, we will hit NodeHost.Stop() called twice panic like below:

exit
panic: NodeHost.Stop called twice

goroutine 1 [running]:
github.com/lni/dragonboat/v4.(*NodeHost).Close(0xc0001bea80)
        /<home-dir>/go/pkg/mod/github.com/lni/dragonboat/[email protected]/nodehost.go:390 +0x9d0
main.main()
        /<git-repo>/dragonboat-example/multigroup/main.go:195 +0x88c


          Fix inconsistency of flags in multigroup example

58d0ad7

Fix NodeHost.Stop called twice problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet