Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Builds and Tests all major versions of Java on Ubuntu and MacOS. #638

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CI Builds and Tests all major versions of Java on Ubuntu and MacOS. #638

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a0b57f
Github actions can build and test major Java versions on the three po…
carldea Nov 19, 2020
929f741
Added Java 8, 8.0.192 to matrix for building and testing.
carldea Nov 19, 2020
8d8f34c
Builds and tests all major Java versions on the latest Ubuntu and Mac…
carldea Nov 19, 2020
ec874c7
Only include major versions of Java.
carldea Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,20 @@ on: [push, pull_request]

jobs:
build-and-test:
runs-on: ubuntu-latest

runs-on: ${{ matrix.os }}
strategy:
matrix:
java: [8, 8.0.192, 11, 11.0.9, 12, 13, 13.0.4, 14.0.2, 15]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just leave it to the major versions and not the patch releases, also why test versions that are already EOL (OpenJDK 12 /13 / 14 have all passed)...
I'd just stick to LTS versions (8 and 11)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael,
Sounds good to avoid patch release, however I’d keep all major versions. I and others use Java/JavaFX 14 & 15!
Btw, I did test 16ea and it failed for some reason so I took it out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you agree with me. Did you want me to make the change or will you make the change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had made the change to remove EOL and patched versions.

os: [ubuntu-latest, macOS-latest]
carldea marked this conversation as resolved.
Show resolved Hide resolved
fail-fast: false
max-parallel: 4
name: Build and Test JDK ${{ matrix.java }}, ${{ matrix.os }}
steps:

- uses: actions/checkout@v2
- name: Set up JDK 1.8
- name: Set up JDK
uses: actions/setup-java@v1
with:
java-version: 1.8
java-version: ${{ matrix.java }}
- uses: actions/cache@v1
with:
path: ~/.m2/repository
Expand Down