refactor: Use is_empty instead of len() == 0 comparisons (#339)

locka99 · Jul 23, 2024 · c75b1bb · c75b1bb
1 parent ce9cd86
commit c75b1bb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/src/client/session/services/subscriptions/service.rs b/lib/src/client/session/services/subscriptions/service.rs
@@ -807,7 +807,7 @@ impl Session {
         let acks = {
             let mut subscription_state = trace_lock!(self.subscription_state);
             let acks = subscription_state.take_acknowledgements();
-            if acks.len() > 0 {
+            if !acks.is_empty() {
                 Some(acks)
             } else {
                 None

diff --git a/lib/src/server/services/message_handler.rs b/lib/src/server/services/message_handler.rs
@@ -617,7 +617,7 @@ impl MessageHandler {
         let session_diagnostics = session.session_diagnostics();
         let mut session_diagnostics = trace_write_lock!(session_diagnostics);
         Self::diag_authorized_request(&mut session_diagnostics, authorized);
-        if diagnostic_key.len() > 0 {
+        if !diagnostic_key.is_empty() {
             let service_success = if let SupportedMessage::ServiceFault(_response) = response {
                 false
             } else {

diff --git a/samples/demo-server/src/methods.rs b/samples/demo-server/src/methods.rs
@@ -94,7 +94,7 @@ impl callbacks::Method for Boop {
                 } else {
                     StatusCode::BadInvalidArgument
                 }
-            } else if input_arguments.len() == 0 {
+            } else if input_arguments.is_empty() {
                 return Err(StatusCode::BadArgumentsMissing);
             } else {
                 // Shouldn't get here because there is 1 argument
@@ -159,7 +159,7 @@ impl callbacks::Method for HelloX {
                 } else {
                     StatusCode::BadTypeMismatch
                 }
-            } else if input_arguments.len() == 0 {
+            } else if input_arguments.is_empty() {
                 return Err(StatusCode::BadArgumentsMissing);
             } else {
                 // Shouldn't get here because there is 1 argument