clippy

src/controller/backtrace.rs

@@ -60,8 +60,8 @@ pub fn print_backtrace(bt: &std::backtrace::Backtrace) -> Result<()> {
     backtrace_printer::print_backtrace(
         &mut std::io::stdout(),
         bt,
-        &get_name_blocklist(),
-        &get_file_blocklist(),
+        get_name_blocklist(),
+        get_file_blocklist(),
     )
     .map_err(Error::msg)
 }

src/controller/middleware/remote_ip.rs

@@ -165,7 +165,7 @@ fn maybe_get_forwarded(
             // trusted proxies provided REPLACES our default local proxies
             let proxies = trusted_proxies
                 .as_ref()
-                .unwrap_or(&get_local_trusted_proxies());
+                .unwrap_or_else(|| get_local_trusted_proxies());
             !proxies
                 .iter()
                 .any(|trusted_proxy| trusted_proxy.contains(*ip))

src/testing.rs

@@ -105,7 +105,7 @@ fn get_cleanup_mail() -> &'static Vec<(&'static str, &'static str)> {
 /// ```
 #[must_use]
 pub fn cleanup_user_model() -> Vec<(&'static str, &'static str)> {
-    let mut combined_filters = get_cleanup_user_model().to_vec();
+    let mut combined_filters = get_cleanup_user_model().clone();
     combined_filters.extend(get_cleanup_date().iter().copied());
     combined_filters.extend(get_cleanup_model().iter().copied());
     combined_filters
@@ -114,7 +114,7 @@ pub fn cleanup_user_model() -> Vec<(&'static str, &'static str)> {
 /// Combines cleanup filters from emails  that can be dynamic
 #[must_use]
 pub fn cleanup_email() -> Vec<(&'static str, &'static str)> {
-    let mut combined_filters = get_cleanup_mail().to_vec();
+    let mut combined_filters = get_cleanup_mail().clone();
     combined_filters.extend(get_cleanup_date().iter().copied());
     combined_filters
 }