-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starters: 0.12.0 updates (remove notes, devcontainer, prefix + more) #846
Conversation
jondot
commented
Oct 14, 2024
•
edited
Loading
edited
- clean up docs (where 'notes' is mentioned)
- create a devcontainer repo with a README, like this: https://github.com/theomessin/laravel-devcontainer
fixes #820 |
@jondot Looking at the changes, it looks like you are completely changing the saas starter template to be a clean template instead. I'm wondering if there is value in creating two saas templates:
This way, we can serve both new users who want something to explore as well as existing users who just need a plain skeleton to start. One example of an existing well-known framework that has both options like so is SvelteKit: |
question: why remove the containers? |
@ephbaum we've gotten feedback that sometimes (because of how VSCode works) a pop up jumps in, people click "accept" and then a container workflow starts and from there confusion starts. we're going to introduce this back as a @darricheng we've gotten requests to remove the "boilerplate" because as people adopt Loco, they anyways start cleaning that up. That, combined with the ability to generate full scaffold now, makes the sample |
@jondot I think what you said makes a lot of sense. A full-featured example like a working todo app would definitely be much better for the desired outcome of letting users explore a working app than just having a skeleton with a notes scaffold added to it. |
Thanks for the reply @jondot, that makes sense I asked because this is one of the few projects where the devcontainer configuration actually works pretty well from the start and didn't want to see it removed entirely My only (devcontainer) complaint from toying with the SaaS starter is not having node available by default - in my case I simply installed node via I've found some bugs and behavioral quirks (such as the bad links in the welcome email for at least the saas starter) but overall I see a lot of potential for Loco and I'm excited to see where it goes from here. Thanks again for taking the time to reply, I appreciate it 🙏 |
Just checking out loco for a side project and I ran into this PR and wanted to note my approval. The first thing I did was start ripping out the notes model. |
devcontainer now here: https://github.com/loco-rs/loco-devcontainer |