Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong injection in migration/lib.rs #922

Closed
wants to merge 1 commit into from

Conversation

kaplanelad
Copy link
Contributor

@kaplanelad kaplanelad commented Oct 28, 2024

Following the changes in #887, the migration was not correctly injected into migration/lib.rs.
See error example here: https://github.com/loco-rs/loco/actions/runs/11548816568/job/32140819625

To fix this fast, I updated the injection rule by moving it above the current injection point and added a newline comment (//) as a marker for the injection rule.

@jondot
Copy link
Contributor

jondot commented Oct 28, 2024

Thanks fixed via 7bb5e4c

@jondot jondot closed this Oct 28, 2024
@ABruel
Copy link
Contributor

ABruel commented Nov 2, 2024

Thanks fixed via 7bb5e4c

Couldn't find the pr for this change, so I'll comment here. inject-below doesn't seem to work, should probably be inject-above. See #949.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants