Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relevant meta tags for better defaults #943

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

darricheng
Copy link
Contributor

I think we can add the following two meta tags to the base html templates as a better default over the starting templates.

  • charset utf-8: I think it's good practice to define the charset, at least that's what w3 recommends as well.
  • viewport: Based on mdn, this tag is used by browsers to scale webpages for non-mobile optimised pages. I think that designing websites to account for mobile should be pretty common given the widespread use of mobile devices, so adding this tag to start should be better than not having it. (I was confused about the appearance of my website not scaling as I expected when developing, which led me to the discovery of this tag.)

@darricheng darricheng changed the title feat: add relevant meta tags for better defaults Add relevant meta tags for better defaults Oct 31, 2024
@jondot jondot merged commit e0b50ac into loco-rs:master Oct 31, 2024
15 of 16 checks passed
@darricheng darricheng deleted the improve-base-html-defaults branch October 31, 2024 14:14
@jondot jondot added this to the 0.13.0 milestone Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants