Try renaming submissionId to id for input
#3711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
added
preview
theosanderson
force-pushed
the
submissionid2id
branch
from
39e8342 to
7c7e241
Compare
fhennig
reviewed
Feb 24, 2025
| @@ -150,8 +151,8 @@ function getAccessionInputField(): InputField { | |||
|
|
|||
| function getSubmissionIdInputField(): InputField { | |||
| return { | |||
| name: SUBMISSION_ID_FIELD, | |||
| displayName: 'Submission ID', | |||
| name: SUBMISSION_ID_INPUT_FIELD, | |||
There was a problem hiding this comment.
I wouldn't add the _INPUT part to this field name - why did you think of doing that? Other fields are also inputs possibly, and the don't have this.
|
Looks all very sensible, nice! I would like to have two more backend tests:
If that's there and tests are green I think I would approve. EDIT: Oh yes, probably also some docs. - |
|
I've removed the preview label here for now, feel free to add it back! Just a bit many small PRs going on at the moment (I created a lot of them 😬 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2404
preview URL: https://submissionid2id.loculus.org/
Summary
Asking users to supply a metadata file with a "submissionId" for each sequence is confusing. The ID here is actually likely to be the user's own sample ID, as used in their FASTA file. "SubmissionID" implies an association specifically with the Loculus submission - maybe an ID for submission that you get from Loculus.
Here we rename this input field to a bare
id, and also adjust the templates accordingly. We have back-compatibility that also supportssubmissionId(we can potentially remove that after a while).This does not rename the field downstream. After submission this name does make more sense, it distinguishes the name that Loculus assigned (the accession) from the one the user used at submission (the
submissionId)PR Checklist