-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s dependencies to 1.32 #2427
Conversation
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
1efaf93
to
0ad0fe1
Compare
EDIT: This test is fixed and solution has been added to the PR There are two more tests which are failing. These tests were recently added in conformance test suite (a couple of months back). Below are the tests and the RCA:
Why are these tests failing? These tests perform the lifecycle operations (CRUD) for nodes and CSI nodes on vcluster respectively but since vcluster doesn't inherently support the node creation on the virtual cluster, so Probable Solutions: Since this is a case of a feature not supported so ideally it should be skipped but that might impact the certification failure as mentioned in conformance test instructions.
Let me know your opinions and based on that I will create the PR to fix these remaining 2 conformance tests. |
4b135de
to
d387224
Compare
Signed-off-by: Amruta Kale <[email protected]>
d387224
to
c237785
Compare
Original PR was here, I will close: #2388 |
63d135b
to
935284f
Compare
935284f
to
5500335
Compare
aaab73d
to
6b70940
Compare
6b70940
to
45f8e0e
Compare
3fdff1c
to
931f8a3
Compare
931f8a3
to
f2c9309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions and suggestions to try.
43bd1a3
to
00fd0bd
Compare
00fd0bd
to
eea94e2
Compare
eea94e2
to
a345049
Compare
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind feature
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves ENG-5389
resolves ENG-5387
resolves ENG-5428
Please provide a short message that should be published in the vcluster release notes
Updated vcluster Kubernetes dependencies to v1.32
What else do we need to know?
This PR also fixes vcluster for failing conformance tests because of following issues:
status.qosClass
has been made immutable from k8s version 1.32 as done over here. When there is a mismatch instatus.qosClass
field in vcluster and host cluster and vlcuster tries to patch the field in vcluster, the patch fails with an error. This causes conformance tests to fail. The PR fixes tests by ignoring this field in the pod syncer patch updates.Job should allow to use a pod failure policy to ignore failure matching on DisruptionTarget condition [Conformance]
was failing because the job controller on vcluster expected the pod to be infailed
state before deleting it.In this case when the host pod is marked for deletion, the host pod gets into
Failed
state. But these status updates were not getting propogated to vcluster pod. This led to vcluster pod to be dangling state which caused the test failure. The PR adds a fix of propogating the status updates of host pod to vcluster pod when the host pod is marked for deletion.should run through the lifecycle of a node
andshould run through the lifecycle of a csinode
was failing because these tests perform the lifecycle operations (CRUD) for nodes and CSI nodes on vcluster respectively but since vcluster doesn't inherently support the node creation on the virtual cluster, sosyncToHost
method simply deletes the node that was created during the conformance test. Hence, the test can't perform any further action such as get or update and the test fails.This PR fixes these tests as well