Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce reuse-namespace config for creating multiple vClusters in same ns #2538

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ApsTomar
Copy link
Contributor

@ApsTomar ApsTomar commented Feb 25, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-5919

Please provide a short message that should be published in the vcluster release notes
For v0.24, it will be mandatory set reuse-namespace=true in vcluster config to create multiple vclusters in same ns, failing to which the vcluster pod won't come up.

What else do we need to know?

Testing scenarios:

  • Using helm, when the user creates another vcluster without giving setting reuse-namespace config to true:

image

  • Using CLI, the creation should fail if inside vcluster config reuse-namespace=true is not set even if --reuse-namespace flag used:

image

  • When user created it using CLI in v0.22 and upgrades to v0.24 then also the pod should fail with the same warning if the config is not set to true:
    (testing it at the moment)

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c7913db
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/67bdf2dba593b40008ffb776

@ApsTomar ApsTomar marked this pull request as draft February 25, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant