Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependency on "six" #4950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-detiste
Copy link

Hi !

Six was a comatibility layer used to have a billingual Python 2+3 codebase

https://wiki.debian.org/Python3-six-removal

@joachimmetz
Copy link
Member

@a-detiste thanks for the changes, have you double checked that all dependencies+python versions really no longer need it on Windows, Linux and MacOS?

@a-detiste
Copy link
Author

Hi, I only use linux (and grep) but have removed six from hundred of packages https://wiki.debian.org/Python3-six-removal

If there's no import six left in the code what could go wrong on Windows ?

@joachimmetz
Copy link
Member

joachimmetz commented Jan 20, 2025

If there's no import six left in the code what could go wrong on Windows ?

depends on the installation method, if a required dependency of a dependency, a deployment could fail to run. I'll have a closer look when time permits. Marking as blocked for now

@joachimmetz joachimmetz self-assigned this Jan 20, 2025
@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work cannot progress until another issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants