Add validation for each provider when adding a custom model #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to logancyang#1004 Implement validation logic for each provider when adding a custom model. * **`src/settings/model.ts`**: - Add `validateSettings` and `validateModelConfig` functions to validate model configurations. - Implement provider-specific validation functions for OpenAI, Azure OpenAI, Anthropic, CohereAI, Google, OpenRouterAI, Groq, Ollama, LM Studio, and OpenAI Format. - Modify `setSettings` and `updateSetting` functions to include validation before updating settings. * **`README.md`**: - Add a troubleshooting section with common validation errors and their solutions. * **`src/settings/components/ApiSettings.tsx`**: - Add state management for validation errors and invalid fields. - Modify `handleUpdateSetting` function to handle validation and update settings. - Display validation error messages and highlight invalid fields in the UI. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/logancyang/obsidian-copilot/issues/1004?shareId=XXXX-XXXX-XXXX-XXXX).
* **Validation and Error Handling** - Add validation logic to `setSettings` and `updateSetting` functions in `src/settings/model.ts` - Add error logging and user feedback for validation errors in `setSettings` and `updateSetting` functions - Prevent settings update if validation errors occur in `setSettings` and `updateSetting` functions * **UI Enhancements** - Add `ModelSettingsComponent.tsx` to highlight invalid fields in custom model configuration UI based on validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1004
Implement validation logic for each provider when adding a custom model.
src/settings/model.ts:validateSettingsandvalidateModelConfigfunctions to validate model configurations.setSettingsandupdateSettingfunctions to include validation before updating settings.README.md:src/settings/components/ApiSettings.tsx:handleUpdateSettingfunction to handle validation and update settings.For more details, open the Copilot Workspace session.