feat: CU-1n5w3vb add loading and variants to badge #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-1n5w3vb Badges: update and clean code |
snqb
commented
Dec 6, 2021
| } | ||
|
|
||
| // this is a workaround because styled-system does not support theme colors for `linear-gradient` |
snqb
force-pushed
the
CU-1n5w3vb_Badges-update-and-clean-code_Esen-Dzhailobaev
branch
from
098eb2c to
29d02db
Compare
snqb
commented
Dec 6, 2021
| @@ -69,7 +69,8 @@ const theme: ITheme = { | |||
| red: '#EB5757', | |||
| orange: '#f2994a', | |||
| purple: '#9B51E0', | |||
| yellow: '#FFF066', | |||
| yellow: '#FFE600', | |||
There was a problem hiding this comment.
this yellow was just wrong, see Figma
snqb
commented
Dec 6, 2021
| '> span': { | ||
| color: 'white', | ||
| color: 'grayShade3', |
There was a problem hiding this comment.
the base color was changed
snqb
changed the title
giardiv
approved these changes
Dec 6, 2021
ErmiasG
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: https://app.clickup.com/t/1n5w3vb
This PR adds:
modeiconpropBREAKING:
this PR removes these values from
variantprop:bold, which is replaced withdefaultnowborder, we now use themode="bordered"To be noted:
warningvariant colors are changed, but this should not lead to changes to the code, as the semantics stay the sameDEMO:
bandicam.2021-12-06.21-40-51-888.mp4