Set x-elastic-product-origin header for ES requests #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
commented
Nov 11, 2024
lib/logstash/inputs/elasticsearch.rb
Outdated
| @@ -271,6 +271,8 @@ class LogStash::Inputs::Elasticsearch < LogStash::Inputs::Base | |||
|
|
|||
| BUILD_FLAVOR_SERVERLESS = 'serverless'.freeze | |||
| DEFAULT_EAV_HEADER = { "Elastic-Api-Version" => "2023-10-31" }.freeze | |||
| # CODEREVIEW: What should the value be here? Logstash? Logstash-plugin? | |||
| INTERNAL_ORIGIN_HEADER = { 'x-elastic-internal-origin' => 'logstash-input-elasticsearch'}.freeze | |||
There was a problem hiding this comment.
What should the value be for plugins? Do we want it to be unique for each plugin? Do we want to indicate the request is coming from a plugin at all? Should it just be something even more generic like "logstash"?
donoghuc
changed the title
donoghuc
force-pushed
the
ID-4384-x-elastic-internal-origin-header
branch
from
38cf55f
to
1c54650
Compare
This commit updates the `Elasticsearch::Client` used to make requests to ES to send along a header identifying the request as originating from an internal component.
donoghuc
force-pushed
the
ID-4384-x-elastic-internal-origin-header
branch
from
1c54650
to
9fce225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
Elasticsearch::Clientused to make requests to ES to send along a header identifying the request as originating from an internal component.Closes #212