Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46.
The way KCL is configured has changed between v1 and v2, configuration values are stored in separate POJOs now so there can't just be a single
additional_options
block that allows everything to be changed.Since the consumer now has to instantiate the clients it wants to use itself there will have to be separate configuration values for setting things like Kinesis endpoint (so there has been a regression on items like #49 since #51) -
endpointOverride
takes aURI
and unsure how we'd handle that without addingkinesis_endpoint
,cloudwatch_endpoint
, etc configuration values separately, open to any suggestions if that should be in the scope of this PR.Note: this is a breaking change as it requires the following extra permissions to be added to the IAM role being assumed by logstash:
SubscribeToShard
DescribeStreamSummary
DescribeStreamConsumer
RegisterStreamConsumer