Sleep duration as a config parameter

[dkaminski]

When a batch read on a list returns no results,
sleep for the specified number of seconds.

[jordansissel]

Thanks for helping improve Logstash!

I am not sure I understand the intended effect of this change. Why would a
user change this value? What is the expected benefit?

On Tue, Nov 22, 2016 at 3:13 PM Dave Kaminski [email protected]
wrote:

When a batch read on a list returns no results,

sleep for the specified number of seconds.

You can view, comment on, or merge this pull request online at:

#53
Commit Summary

• Sleep duration as a config parameter

File Changes

• M lib/logstash/inputs/redis.rb
  https://github.com/logstash-plugins/logstash-input-redis/pull/53/files#diff-0
  (7)

Patch Links:

https://github.com/logstash-plugins/logstash-input-redis/pull/53.patch

• https://github.com/logstash-plugins/logstash-input-redis/pull/53.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#53, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIC6i9bZJ3LW0c0SuNT_lm5vYsq1zwvks5rA3cJgaJpZM4K6DkO
.

[dkaminski]

The intent is to throttle the polling loop when a Redis list is empty and infrequently populated. I have a Logstash installation that reads a Redis list, but I do not control the service that writes to the list (so I cannot switch to pub-sub). The writes have become infrequent and I would like to have the ability to poll less often.

Also, I could work on rewriting the failing timing test if you feel that this has a chance of being accepted.

[jordansissel]

I would prefer if users didn't need to configure this kind of thing. Configuring the delay seems like a workaround for a bug.

In terms of implementation, if we still need this kind of thing, my preference would be to add a mechanism within the plugin to automatically switch to BLPOP if the data rate is slow enough. This would have the same benefit (if any?) of increasing the polling interval while avoiding adding a new configuration setting.

That is, instead of sleeping, we call BLPOP and queue that single event?

[dkaminski]

That's a good point about a dynamic switch to BLPOP. For the time being though I am going to work on switching my current setup to pub-sub. That is the proper way to handle infrequent or irregular data, correct? That's my intuition but i'm no expert.

Thanks for the thoughts and prompt responses on this. Feel free to close it.