Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change loading ca-bundle logic #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agolotin
Copy link

Hi!

Several months ago I came across an issue. Let's assume this is my configuration:

input {
    tcp {
        port => 9000
        type => syslog
        ssl_enable => true
        ssl_cert => '${SOME_CRT}'
        ssl_key => '${SOME_KEY}'
        ssl_extra_chain_certs => ['${SOME_CA_BUNDLE}']
        ssl_verify => false
    }
}

If my certificate is actually signed by a real certificate authority, then I have to provide the entire CA-bundle in order for the cert to match the key. However, if I do not want my certificate to be actually verified in peer mode (I'm debugging, and using a server with a different hostname), if I disable such verification, then it essentially the same as if I did not even provide ssl_extra_chain_certs argument.

My pull request fixes this logic. So in case you have to provide a ca-bundle separately from your cert file and disable ssl_verify, you now can.

@patrobinson
Copy link

Bump cc @jordansissel @danhermann

This is a very simple fix and something I needed today

patrobinson pushed a commit to envato-archive/logstash-input-tcp that referenced this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants