Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix create org role API #6894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Dec 19, 2024

Summary

fix create org role API:
Previously, if organizationScopeIds or resourceScopeIds contained an invalid ID (such as a non-existent scope ID), the API would return a 4xx error, but the role would still be created. In reality, the role should not have been created.

Repored by community users in issue 6891.

Testing

Add integration tests to cover these scenarios.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Dec 19, 2024

COMPARE TO master

Total Size Diff 📈 +4.26 KB

Diff by File
Name Diff
.changeset/thick-baboons-sniff.md 📈 +214 Bytes
packages/core/src/routes/organization-role/index.openapi.json 📈 +167 Bytes
packages/core/src/routes/organization-role/index.ts 📈 +877 Bytes
packages/integration-tests/src/tests/api/organization/organization-role.test.ts 📈 +2.88 KB
packages/phrases/src/locales/en/errors/organization.ts 📈 +157 Bytes

@darcyYe darcyYe force-pushed the yemq-fix-post-org-roles-API branch from 2c73686 to bdebf2a Compare December 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant