Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): add Xiaomi social login connector #6905

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

u0x01
Copy link

@u0x01 u0x01 commented Dec 23, 2024

Summary

Added Xiaomi social connector to enable users to sign in to Logto using their Xiaomi accounts. Key features include:

  • Implemented Xiaomi OAuth 2.0 authorization flow
  • Support fetching user profile information (avatar, nickname, etc.)
  • Configurable authorization scope and skip xiaomi auth confirmation page option
  • Comprehensive unit test coverage

Testing

  • Added complete unit tests covering:
    • Get authorization URI
    • Exchange access token
    • Fetch user info
    • Error handling scenarios
  • Manual testing completed in local environment to verify the full authorization flow

Checklist

  • .changeset
  • unit tests
  • integration tests - N/A for this connector
  • necessary TSDoc comments

Copy link

github-actions bot commented Dec 23, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +23.53 KB

Diff by File
Name Diff
.changeset/rotten-lizards-buy.md 📈 +70 Bytes
packages/connectors/connector-xiaomi/README.md 📈 +3.02 KB
packages/connectors/connector-xiaomi/README.zh-CN.md 📈 +2.9 KB
packages/connectors/connector-xiaomi/logo.svg 📈 +1.69 KB
packages/connectors/connector-xiaomi/package.json 📈 +1.68 KB
packages/connectors/connector-xiaomi/src/constant.ts 📈 +1.69 KB
packages/connectors/connector-xiaomi/src/index.test.ts 📈 +4.26 KB
packages/connectors/connector-xiaomi/src/index.ts 📈 +4.84 KB
packages/connectors/connector-xiaomi/src/mock.ts 📈 +578 Bytes
packages/connectors/connector-xiaomi/src/types.ts 📈 +1.2 KB
pnpm-lock.yaml 📈 +1.6 KB

@u0x01 u0x01 force-pushed the feature/connector-xiaomi branch from 2cd7918 to f6cda2e Compare December 23, 2024 12:26
@u0x01 u0x01 force-pushed the feature/connector-xiaomi branch from f6cda2e to b64aa22 Compare December 24, 2024 08:41
@charIeszhao charIeszhao force-pushed the feature/connector-xiaomi branch from aa7e3f9 to 0200f09 Compare December 25, 2024 04:33
@charIeszhao charIeszhao self-requested a review December 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants