Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): add YunPian SMS connector #6906

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

u0x01
Copy link
Contributor

@u0x01 u0x01 commented Dec 23, 2024

Summary

Added YunPian SMS connector to support SMS verification code sending via YunPian service provider.

Key features:

  • Implemented YunPian SMS connector with full test coverage
  • Added configuration validation and error handling
  • Support both domestic (China) and international phone numbers
  • Added comprehensive documentation in Chinese
  • Included YunPian logo assets

Testing

  • Added unit tests for connector initialization and message sending
  • Tested with mocked API responses using nock
  • Verified error handling for various scenarios
  • Tested phone number formatting for both domestic and international numbers

Checklist

  • .changeset - Added minor version bump for connector
  • Unit tests - Added comprehensive test coverage
  • Integration tests - N/A for this connector
  • TSDoc comments - Added necessary documentation

Copy link

github-actions bot commented Dec 23, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +19.33 KB

Diff by File
Name Diff
.changeset/brown-donkeys-share.md 📈 +73 Bytes
packages/connectors/connector-xiaomi/package.json 📈 +46 Bytes
packages/connectors/connector-yunpian-sms/README.md 📈 +2.65 KB
packages/connectors/connector-yunpian-sms/README.zh-CN.md 📈 +2.34 KB
packages/connectors/connector-yunpian-sms/logo.svg 📈 +2.06 KB
packages/connectors/connector-yunpian-sms/package.json 📈 +1.64 KB
packages/connectors/connector-yunpian-sms/src/constant.ts 📈 +2.16 KB
packages/connectors/connector-yunpian-sms/src/index.test.ts 📈 +1.25 KB
packages/connectors/connector-yunpian-sms/src/index.ts 📈 +3.53 KB
packages/connectors/connector-yunpian-sms/src/mock.ts 📈 +671 Bytes
packages/connectors/connector-yunpian-sms/src/types.ts 📈 +1.41 KB
pnpm-lock.yaml 📈 +1.59 KB

@u0x01 u0x01 changed the title add YunPian SMS connector feat(connector): add YunPian SMS connector Dec 23, 2024
@github-actions github-actions bot added the feature Cool stuff label Dec 23, 2024
@u0x01 u0x01 force-pushed the feature/connector-yunpian-sms branch from 65b485b to 450591a Compare December 24, 2024 10:13
@charIeszhao charIeszhao force-pushed the feature/connector-yunpian-sms branch from 9b5cafb to 9ad9498 Compare December 30, 2024 12:06
@charIeszhao charIeszhao enabled auto-merge (squash) December 30, 2024 12:07
@charIeszhao charIeszhao merged commit 3004ae9 into logto-io:master Dec 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants