Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] fluentd align to new global structure #577

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Jan 23, 2025

Description

  • Change secret values to global and align the names to prevent duplicate values in the parent chart
    • secrets.logzioShippingToken >> global.logzioLogsToken
    • secrets.logzioListener >> global.logzioRegion
    • secrets.customEndpoint >> global.customLogsEndpoint
    • env_id >> global.env_id
  • K8s secret resource configuration has been renamed secrets >> secret
    • secretName >> secret.name
  • Move changelog from README.md >> CHANGELOG.md
  • Update readme
  • Align tests

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

Copy link
Contributor

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants