Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip_outdated toggle #42

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: add skip_outdated toggle #42

merged 1 commit into from
Mar 27, 2024

Conversation

loiccoyle
Copy link
Owner

Adds an option to toggle the skipping of tickers when its data is not recent (this typically happens when the market closed).

closes #37 #41

fix: fallback to default sequence config settings when reading config

fix: add sequence args to Sequence __str__
@loiccoyle loiccoyle merged commit 28f73ba into main Mar 27, 2024
5 checks passed
@fangfufu
Copy link

Alright, so if skip_outdated is True, then the a stock ticker wouldn't be updated when the stock market is closed. Is that right? So I need to set it to false.

@loiccoyle
Copy link
Owner Author

yeah set it to False if you always want it to display stock data even if the data is old, i.e. the market is currently closed.

@loiccoyle loiccoyle deleted the dev branch April 28, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Make the skip_outdated toggleable
2 participants