Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: use semver tag_sort for release" #90

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Revert "chore: use semver tag_sort for release" #90

merged 1 commit into from
Jul 22, 2024

Conversation

takkyuuplayer
Copy link
Contributor

@takkyuuplayer takkyuuplayer commented Jul 22, 2024 •
edited
Loading

Reverts #87

Fix for

release failed after 0s error=git doesn't contain any tags. Either add a tag or use --snapshot
https://github.com/loilo-inc/canarycage/actions/runs/10007615861/job/27662680323

tag_sort: semver is available only for goreleaser-pro: schema-pro.json v.s. schema.json

@alfnets alfnets merged commit 62ddf51 into main Jul 22, 2024
3 checks passed
@alfnets alfnets deleted the revert-87-tagsort branch July 22, 2024 04:52
alfnets
alfnets reviewed Jul 22, 2024
View reviewed changes
Copy link

@alfnets alfnets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alfnets
Copy link

alfnets commented Jul 22, 2024

ref. https://goreleaser.com/blog/goreleaser-v1.21/?h=semver#highlights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfnets alfnets alfnets left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takkyuuplayer @alfnets