incorporating code review comments.

Signed-off-by: lrangine <[email protected]>
lokeshrangineni · Feb 7, 2025 · 77fe297 · 77fe297
1 parent 3d239a6
commit 77fe297
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml b/infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml
@@ -17,18 +17,18 @@ metadata:
   namespace: default
 stringData:
   sql: |
-    path: postgresql+psycopg://admin:password@postgresql.default.svc.cluster.local:5432/mydatabase?sslmode=require&sslrootcert=/var/lib/postgresql/certs/ca.crt&sslcert=/var/lib/postgresql/certs/tls.crt&sslkey=/var/lib/postgresql/certs/tls.key
+    path: postgresql+psycopg://${POSTGRES_USER}:${POSTGRES_PASSWORD}@postgresql.default.svc.cluster.local:5432/${POSTGRES_DB}?sslmode=require&sslrootcert=/var/lib/postgresql/certs/ca.crt&sslcert=/var/lib/postgresql/certs/tls.crt&sslkey=/var/lib/postgresql/certs/tls.key
     cache_ttl_seconds: 60
     sqlalchemy_config_kwargs:
         echo: false
         pool_pre_ping: true
   postgres: |
     host: postgresql.default.svc.cluster.local
     port: 5432
-    database: mydatabase
+    database: ${POSTGRES_DB}
     db_schema: public
-    user: admin
-    password: password
+    user: ${POSTGRES_USER}
+    password: ${POSTGRES_PASSWORD}
     sslmode: require
     sslkey_path: /var/lib/postgresql/certs/tls.key
     sslcert_path: /var/lib/postgresql/certs/tls.crt

diff --git a/infra/feast-operator/internal/controller/services/services.go b/infra/feast-operator/internal/controller/services/services.go
@@ -455,7 +455,7 @@ func (feast *FeastServices) getVolumeMounts(feastType FeastServiceType) (volumeM
 			return appliedServices.OnlineStore.Server.VolumeMounts
 		}
 	case RegistryFeastType:
-		if feast.isLocalRegistry() {
+		if feast.isRegistryServer() {
 			return appliedServices.Registry.Local.Server.VolumeMounts
 		}
 	case UIFeastType: