feat(backupbackingimage): add parameters to backup backing image create proto #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te proto ref: longhorn/longhorn 8884 Signed-off-by: Jack Lin <[email protected]>
derekbit
force-pushed
the
LH8884_store_secret_in_backupbackingimage
branch
from
9303475
to
a0e955b
Compare
derekbit
approved these changes
Aug 26, 2024
derekbit
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#8884
To store the
secretandsecretNamespacetoBackupBackingImageconfigWe need to pass this information through grpc call to
backing-image-managerAs discussed, we can use a general
parametersto pass these meta information