fix: add a unit test

Add a unit test that verifies the scaffold when explicity specifying the controller type as BASIC Signed-off-by: TC <[email protected]>
loopbackio · Aug 20, 2024 · 860b036 · 860b036
1 parent 500e20b
commit 860b036
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
@@ -0,0 +1 @@
+./docs/CODE_OF_CONDUCT.md
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -0,0 +1 @@
+./docs/CONTRIBUTING.md
diff --git a/MAINTAINING.md b/MAINTAINING.md
diff --git a/MAINTAINING.md b/MAINTAINING.md
@@ -0,0 +1 @@
+./docs/MAINTAINING.md
diff --git a/packages/cli/test/integration/generators/controller.integration.js b/packages/cli/test/integration/generators/controller.integration.js
@@ -24,8 +24,12 @@ const {expectFileToMatchSnapshot} = require('../../snapshots');
 const sandbox = new TestSandbox(path.resolve(__dirname, '../.sandbox'));
 
 // CLI Inputs
+const defaultCLIInput = {
+  name: 'productReview',
+};
 const basicCLIInput = {
   name: 'productReview',
+  controllerType: 'ControllerGenerator.BASIC',
 };
 const restCLIInput = {
   name: 'productReview',
@@ -54,7 +58,7 @@ describe('lb4 controller', () => {
         .inDir(sandbox.path, () =>
           testUtils.givenLBProject(sandbox.path, {excludePackageJSON: true}),
         )
-        .withPrompts(basicCLIInput),
+        .withPrompts(defaultCLIInput),
     ).to.be.rejectedWith(/No package.json found in/);
   });
 
@@ -65,12 +69,21 @@ describe('lb4 controller', () => {
         .inDir(sandbox.path, () =>
           testUtils.givenLBProject(sandbox.path, {excludeLoopbackCore: true}),
         )
-        .withPrompts(basicCLIInput),
+        .withPrompts(defaultCLIInput),
     ).to.be.rejectedWith(/No `@loopback\/core` package found/);
   });
 
   describe('basic controller', () => {
     it('scaffolds correct file with input', async () => {
+      await testUtils
+        .executeGenerator(generator)
+        .inDir(sandbox.path, () => testUtils.givenLBProject(sandbox.path))
+        .withPrompts(defaultCLIInput);
+
+      checkBasicContents();
+    });
+
+    it('scaffolds correct file with controllerType BASIC specified explicitly', async () => {
       await testUtils
         .executeGenerator(generator)
         .inDir(sandbox.path, () => testUtils.givenLBProject(sandbox.path))