feat(booter-lb3app): enable operation-scoped model schemas #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LB3 models with `forceId: true` require request bodies for CREATE operations to exclude the primary key (id property). This commit turns on a loopback-swagger feature flag to describe this constraint in the emitted Swagger spec.
raymondfeng
approved these changes
May 2, 2019
hacksparrow
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LB3 models with
forceId: truerequire request bodies for CREATE operations to exclude the primary key (id property), because the value is always generated by the database (e.g. as auto-incremented number, or as a UUID/GUID value).This patch turns on a loopback-swagger feature flag to describe this constraint in the emitted Swagger spec. See the internal story https://github.com/strongloop-internal/scrum-asteroid/issues/283 and the following LB3 pull requests:
I tested the change using LB3 example application from #2803.
The
createendpoint forUsermodel DOES NOT accept "id" property now:The
patchOrCreateendpoint forUsermodel DOES accept "id" property as before:Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈