-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support ReferencesMany relation #8271
feat: adds support ReferencesMany relation #8271
Conversation
Done |
Pull Request Test Coverage Report for Build 1940408176Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Looks like no one needs this add-on, sadness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM 👍 Will see if any of the other maintainers have any objection.
examples/references-many/src/__tests__/acceptance/customer.acceptance.ts
Show resolved
Hide resolved
Redundant property |
Thanks, @mikeevstropov. I'll try to set some time to review the latest changes soon. |
@mikeevstropov, your PR is almost good to go. Could you please squash the commits, esp the ones with cc @achrinza |
01425c2
to
00cca7d
Compare
@dhmlau Hi. I'm not sure if I did it right, just squashed the commits into one (including "merge" commits). |
@mikeevstropov, hm.. as you pointed out, it has the merged commits, so doesn't look quite right.
The caveat is... I'm not sure if the commands above could fix where we're at. (I tend to make another local copy of the changes before pushing again, because there're quite a lot of changes in this PR). Please give it a try. Hope it works! Thanks. |
@mikeevstropov It seems like most of the changes are localised in the gitCommitHash="$(git log -1 --pretty=%H)"
# Take note of the hash in case you need to reset back to the current state:
echo "$gitCommitHash"
git reset --hard master
git checkout "$gitCommitHash" -- \
packages/repository/src \
examples/references-many \
docs/site/MONOREPO.md \
docs/site/Relations.md \
docs/site/Relation-generator.md \
docs/site/ReferencesMany-relation.md
git status # See the staged files
git commit -s The above commands should cherry-pick all of the files needed. Please confirm everything is in order before doing a In case of a SNAFU, we can get back to this current state by resetting back to the original hash: git reset --hard "$gitCommitHash" As a safety net, me (and I assume @dhmlau as well) have a local copy of this PR in its current state on our machines. If you're not comfortable with this, the maintainers can help make the necessary changes from our end. -- As for the commit message itself, as suggestion may be:
|
#8455 is my attempt at "recovering" the original PR using the steps above. If it looks correct, you can try the above steps against this PR, or we can use that new PR if that's preferred. |
00cca7d
to
acc65e7
Compare
closes: loopbackio#2488 Signed-off-by: Mike Evstropov <[email protected]>
acc65e7
to
30a8d0f
Compare
@achrinza The commit is renamed as you suggest. |
Thanks for your contributions, @mikeevstropov! They have been merged 🎉 |
Definition in Model.
Include in query filter.
Response will contain resolved relations in
accounts
field. E.g.Related
#2488
#1450
#1920
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated