Cache plugins' master flag

Avoiding the overhead of checking with esplugin improves sorting performance by 5%.
loot · Jan 17, 2025 · 3f4319a · 3f4319a
1 parent 9104620
commit 3f4319a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/api/sorting/plugin_sorting_data.cpp b/src/api/sorting/plugin_sorting_data.cpp
@@ -60,6 +60,7 @@ PluginSortingData::PluginSortingData(
 #endif
     plugin_(plugin),
     name_(plugin == nullptr ? std::string() : plugin->GetName()),
+    isMaster_(plugin != nullptr && plugin->IsMaster()),
     group_(userMetadata.GetGroup().value_or(
         masterlistMetadata.GetGroup().value_or(Group::DEFAULT_NAME))),
     masterlistLoadAfter_(masterlistMetadata.GetLoadAfterFiles()),
@@ -92,12 +93,10 @@ PluginSortingData::PluginSortingData(
 
 const std::string& PluginSortingData::GetName() const { return name_; }
 
-bool PluginSortingData::IsMaster() const {
-  return plugin_ != nullptr && plugin_->IsMaster();
-}
+bool PluginSortingData::IsMaster() const { return isMaster_; }
 
 bool PluginSortingData::IsBlueprintMaster() const {
-  return plugin_ != nullptr && plugin_->IsMaster() &&
+  return isMaster_ &&
          plugin_->IsBlueprintPlugin();
 }
 

diff --git a/src/api/sorting/plugin_sorting_data.h b/src/api/sorting/plugin_sorting_data.h
@@ -73,6 +73,7 @@ class PluginSortingData {
 private:
   const PluginSortingInterface* plugin_{nullptr};
   std::string name_;
+  bool isMaster_{false};
   std::string group_;
 
   std::vector<File> masterlistLoadAfter_;