Fix the PR number artifact when triggered from a comment. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The receive action was storing `github.event.number` as an artefact for the comment action to use. However, this field is only set for pull request events. If the workflow is configured to trigger on a comment, the event type is now `issue_comment` as the field is absent. There is an equivalent field at `github.event.issue.number`, but that field is absent for PR events. The easiest way to get the number in a uniform and consistent way is to use the PR metadata we already have at the start of the action.
|
Thanks. @assignUser do you agree? I lack the competence to approve this PR. |
assignUser
approved these changes
May 16, 2024
|
Thanks to both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receive action was storing
github.event.numberas an artefact for the comment action to use. However, this field is only set for pull request events. If the workflow is configured to trigger on a comment, the event type is nowissue_commentas the field is absent.There is an equivalent field at
github.event.issue.number, but that field is absent for PR events. The easiest way to get the number in a uniform and consistent way is to use the PR metadata we already have at the start of the action.