fix: close connection after encountering an exception

lost-illusi0n · Jan 7, 2024 · 71baac4 · 71baac4
1 parent b6dd8cc
commit 71baac4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/mailserver/imap-agent/src/commonMain/kotlin/transports/ImapServerTransport.kt b/mailserver/imap-agent/src/commonMain/kotlin/transports/ImapServerTransport.kt
@@ -13,6 +13,7 @@ import dev.sitar.kmail.message.Message
 import dev.sitar.kmail.utils.connection.Connection
 import dev.sitar.kmail.utils.io.readStringUtf8
 import dev.sitar.kmail.utils.io.readUtf8UntilLineEnd
+import kotlinx.coroutines.cancel
 import kotlinx.coroutines.coroutineScope
 import kotlinx.coroutines.isActive
 import mu.KotlinLogging
@@ -38,6 +39,8 @@ class ImapServerTransport(var connection: Connection) {
                 commandPipeline.process(context)
             } catch (e: Exception) {
                 logger.error(e) { "imap transport stream encountered exception." }
+
+                cancel()
             }
         }
     }

diff --git a/mailserver/pop3-agent/src/commonMain/kotlin/transports/Pop3ServerTransport.kt b/mailserver/pop3-agent/src/commonMain/kotlin/transports/Pop3ServerTransport.kt
@@ -6,10 +6,7 @@ import dev.sitar.kmail.pop3.io.asPop3ServerReader
 import dev.sitar.kmail.pop3.io.asPop3ServerWriter
 import dev.sitar.kmail.pop3.replies.Pop3Reply
 import dev.sitar.kmail.utils.connection.Connection
-import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.coroutineScope
-import kotlinx.coroutines.isActive
-import kotlinx.coroutines.launch
+import kotlinx.coroutines.*
 import mu.KotlinLogging
 
 private val logger = KotlinLogging.logger { }
@@ -30,6 +27,8 @@ class Pop3ServerTransport(val connection: Connection) {
                 commandPipeline.process(context)
             } catch (e: Exception) {
                 logger.error(e) { "pop3 transport stream encountered exception." }
+
+                cancel()
             }
         }
     }