mongoose-nedb driver compatibility #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is required to make the mongoose-nedb driver (https://github.com/aerys/mongoose-nedb) work properly when dealing with query using the "_id" field.
Fix an error when we try to compare values from a null or undefined o…
Fix an issue where options can be null updating a datastore.
…field with an existing corresponding index.
This was referenced Aug 10, 2017
|
Any thoughts on this PR? It would be nice to have nedb working alongside mongoose :) |
|
@willwade AFAIK nedb is not maintained anymore. And we're not using this MR/code. We've switched to: It performs well enough for small (<100k docs) databases. |
|
Awesome. Thanks for the tip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I guess we're not the only one willing to use the awesome NeDB with the great Mongoose.
Those changes are meant to make NeDB work with Mongoose using the following driver:
https://github.com/aerys/mongoose-nedb
IMHO, all those changes are self explanatory.
Please let me know if there is anything I can improve.
Regards,