audio_seqplayer.c cleanup (zeldaret#1274)

* Audio Seqplayer Cleanup * More * Edit description * PR Suggestions * while true * Cleanup function declarations * Extra space, oops * Small fix * PR Suggestions * tatums per beat * Edit comment
louist103 · Jan 3, 2023 · 249a2a0 · 249a2a0
1 parent 9d729dc
commit 249a2a0
Show file tree

Hide file tree

Showing 4 changed files with 676 additions and 593 deletions.
diff --git a/include/z64audio.h b/include/z64audio.h
@@ -8,6 +8,7 @@
 #define TATUMS_PER_BEAT 48
 
 #define IS_SEQUENCE_CHANNEL_VALID(ptr) ((u32)(ptr) != (u32)&gAudioContext.sequenceChannelNone)
+#define SEQ_NUM_CHANNELS 16
 
 #define MAX_CHANNELS_PER_BANK 3
 

diff --git a/src/code/audio_load.c b/src/code/audio_load.c
@@ -1844,7 +1844,7 @@ s32 AudioLoad_ProcessSamplePreloads(s32 resetStatus) {
 
         // Pop requests with isFree = true off the stack, as far as possible,
         // and dispatch the next DMA.
-        for (;;) {
+        while (true) {
             if (gAudioContext.preloadSampleStackTop <= 0) {
                 break;
             }

diff --git a/src/code/audio_playback.c b/src/code/audio_playback.c
@@ -652,7 +652,7 @@ void Audio_NotePoolClear(NotePool* pool) {
                 break;
         }
 
-        for (;;) {
+        while (true) {
             cur = source->next;
             if (cur == source || cur == NULL) {
                 break;