Skip to content

Commit

Permalink
[hw,top_racl_pkg,lint] Explixctely lint the RACL pkg for long file name
Browse files Browse the repository at this point in the history
the RACL might be pulled in in blocl level DV and there pullute tje lint.
Therefore, we need to add a dedicated waiver rather than waiving the
package in the block level, e.g., in Darjeeling.

Signed-off-by: Robert Schilling <[email protected]>
  • Loading branch information
Razer6 committed Feb 3, 2025
1 parent 1f6b6f4 commit af82526
Show file tree
Hide file tree
Showing 8 changed files with 76 additions and 3 deletions.
3 changes: 0 additions & 3 deletions hw/top_darjeeling/lint/top_darjeeling.waiver
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,3 @@ waive -rules SAME_NAME_TYPE -location {spi_device.sv mbx.sv} -regexp {'mbx' is u
# intentionally unused
waive -rules {NOT_READ HIER_NET_NOT_READ} -location {top_darjeeling.sv} -regexp {.*cio_otp_ctrl_test_(en_)?d2p\[7:1\].* is not read} \
-comment "otp test bus made deliberately larger on purpose"

waive -rules {LINE_LENGTH} -location {top_racl_pkg.sv} -regexp {Line length of \[[0-9]+\] exceeds 100 character limit} \
-comment "top_racl_pkg is auto-generated and expected to exceed line length limit"
8 changes: 8 additions & 0 deletions hw/top_darjeeling/lint/top_racl_pkg.waiver
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Copyright lowRISC contributors (OpenTitan project).
# Licensed under the Apache License, Version 2.0, see LICENSE for details.
# SPDX-License-Identifier: Apache-2.0
#
# waiver file for top_racl_pkg

waive -rules {LINE_LENGTH} -location {top_racl_pkg.sv} -regexp {Line length of [0-9]+ exceeds 100 character limit} \
-comment "top_racl_pkg is auto-generated and expected to exceed line length limit"
10 changes: 10 additions & 0 deletions hw/top_darjeeling/top_darjeeling_racl_pkg.core
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,17 @@ filesets:
- rtl/autogen/top_racl_pkg.sv
file_type: systemVerilogSource

files_ascentlint_waiver:
depend:
# common waivers
- lowrisc:lint:common
- lowrisc:lint:comportable
files:
- lint/top_racl_pkg.waiver
file_type: waiver

targets:
default: &default_target
filesets:
- tool_ascentlint ? (files_ascentlint_waiver)
- files_rtl
8 changes: 8 additions & 0 deletions hw/top_earlgrey/lint/top_racl_pkg.waiver
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Copyright lowRISC contributors (OpenTitan project).
# Licensed under the Apache License, Version 2.0, see LICENSE for details.
# SPDX-License-Identifier: Apache-2.0
#
# waiver file for top_racl_pkg

waive -rules {LINE_LENGTH} -location {top_racl_pkg.sv} -regexp {Line length of [0-9]+ exceeds 100 character limit} \
-comment "top_racl_pkg is auto-generated and expected to exceed line length limit"
10 changes: 10 additions & 0 deletions hw/top_earlgrey/top_earlgrey_racl_pkg.core
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,17 @@ filesets:
- rtl/autogen/top_racl_pkg.sv
file_type: systemVerilogSource

files_ascentlint_waiver:
depend:
# common waivers
- lowrisc:lint:common
- lowrisc:lint:comportable
files:
- lint/top_racl_pkg.waiver
file_type: waiver

targets:
default: &default_target
filesets:
- tool_ascentlint ? (files_ascentlint_waiver)
- files_rtl
8 changes: 8 additions & 0 deletions hw/top_englishbreakfast/lint/top_racl_pkg.waiver
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Copyright lowRISC contributors (OpenTitan project).
# Licensed under the Apache License, Version 2.0, see LICENSE for details.
# SPDX-License-Identifier: Apache-2.0
#
# waiver file for top_racl_pkg

waive -rules {LINE_LENGTH} -location {top_racl_pkg.sv} -regexp {Line length of [0-9]+ exceeds 100 character limit} \
-comment "top_racl_pkg is auto-generated and expected to exceed line length limit"
1 change: 1 addition & 0 deletions hw/top_englishbreakfast/top_englishbreakfast.core
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ description: "Technology-independent English Breakfast toplevel"
filesets:
files_rtl_generic:
depend:
- lowrisc:systems:top_earlgrey_racl_pkg
- lowrisc:opentitan:top_englishbreakfast_pwrmgr_pkg
- lowrisc:opentitan:top_earlgrey_alert_handler_pkg
# Manually instantiated
Expand Down
31 changes: 31 additions & 0 deletions hw/top_englishbreakfast/top_englishbreakfast_racl_pkg.core
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
CAPI=2:
# Copyright lowRISC contributors (OpenTitan project).
# Licensed under the Apache License, Version 2.0, see LICENSE for details.
# SPDX-License-Identifier: Apache-2.0
name: "lowrisc:systems:top_englishbreakfast_racl_pkg:0.1"
description: "Autogenerated top_englishbreakfast_racl_pkg used in RTL and DV."
virtual:
- lowrisc:systems:top_racl_pkg

filesets:
files_rtl:
depend:
- lowrisc:tlul:headers
files:
- rtl/autogen/top_racl_pkg.sv
file_type: systemVerilogSource

files_ascentlint_waiver:
depend:
# common waivers
- lowrisc:lint:common
- lowrisc:lint:comportable
files:
- lint/top_racl_pkg.waiver
file_type: waiver

targets:
default: &default_target
filesets:
- tool_ascentlint ? (files_ascentlint_waiver)
- files_rtl

0 comments on commit af82526

Please sign in to comment.