[ownership] Manual cherry-pick of #24643 #26052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
approved these changes
Jan 29, 2025
moidx
approved these changes
Jan 30, 2025
In order to facilitate debuging and manual test flows for ownerhsip transfer, we allow the owner pages to be erased if and only if the chip is in the DEV lifecycle state AND the ROM_EXT was specifically built to allow owner erase. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit a14571e) (cherry picked from commit 129451b)
1. Generate owner and application keys for the `SiVal` user in the CloudKMS instance. Export the public components of those keys to the codebase (see `sw/device/silicon_creator/rom_ext/sival/keys/README.md`). 2. Add the keys to the appropriate exec_envs. 3. Add a config setting `//signing:owner_key_type` for selecting between RSA and ECDSA keys (RSA keys are for the currently released ROM_EXT 0.4). Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit b3af7c1) (cherry picked from commit 35ed76c)
1. Create `dummy` ECDSA application keys for ownership transfer tests. 2. Delete `dummy` RSA application keys. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 2a8092f) (cherry picked from commit 440db25)
cfrantz
force-pushed
the
master-port-24994
branch
from
d06fb4e to
fc0db39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #24643 (by way of #24994).
Note, this PR yields a "dangerously close-to-full ROM_EXT" at 64332 bytes.
Current
masterprior to this PR is 63024 bytes (also very full).