[rules] Rename and change semantiv of extra_bazel_features
#26068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
force-pushed
the
compiler_features_rework
branch
from
81d5f3c to
0a9a024
Compare
cfrantz
approved these changes
Jan 30, 2025
Comment on lines
242
to
245
| transitive_features = [ | ||
| "minsize", | ||
| "use_lld", | ||
| ], |
There was a problem hiding this comment.
Any issue with just enabling these globally in the rv32imc toolchain?
There was a problem hiding this comment.
I haven't tried yet, I will create a PR to try it. I don't think there is any harm in explicitely specifying it for important targets such as rom_ext.
pamaury
force-pushed
the
compiler_features_rework
branch
2 times, most recently
from
794a936 to
7b54615
Compare
The `extra_bazel_features` attribute was added lowRISC#25840 as an attribute to `rv_rule` to transitively add features to the rule. However this is too general because when applied to opentitan_binary, it will change the features not only for the rule, but all its dependencies such as exec_env, tools, etc which may have unintended effects. This commit keeps essentially the same logic but instead of applying it to `rv_rule`, it is now only an attribute of `opentitan_binary` and `opentitan_test` and it transitions only features for the `deps`. This attribute is also renamed to `transitive_features`. The rationale for the rename is that every bazel rule has an implicit `features` argument but it only applies to the target, not its dependencies. This attribute does the same but also applies transitively. Signed-off-by: Amaury Pouly <[email protected]>
pamaury
force-pushed
the
compiler_features_rework
branch
from
7b54615 to
d7cd8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
extra_bazel_featuresattribute was added #25840 as an attribute torv_ruleto transitively add features to the rule. However this is too general because when applied to opentitan_binary, it will change the features not only for the rule, but all its dependencies such as exec_env, tools, etc which may have unintended effects.This commit keeps essentially the same logic but instead of applying it to
rv_rule, it is now only an attribute ofopentitan_binaryandopentitan_testand it transitions only features for thedeps. This attribute is also renamed totransitive_features. The rationale for the rename is that every bazel rule has an implicitfeaturesargument but it only applies to the target, not its dependencies. This attribute does the same but also applies transitively.