[bazel,python] update rules_python and vendor in requirements.bzl #26090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
requested review from
mundaym,
a team and
msfschaffner
as code owners
timothytrippel
requested review from
eshapira
and removed request for
a team,
mundaym and
msfschaffner
This updates rules_python to 0.39.0 to match the version on the master branch. See lowRISC#24781. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
update-rules-python
branch
2 times, most recently
from
9d97e46 to
b2c2529
Compare
cfrantz
approved these changes
Feb 1, 2025
Comment on lines
+24
to
+36
| cmd = " | ".join([ | ||
| "cat $<", | ||
| # Substitute the name of the hub to ensure that the dependencies do | ||
| # not require the hub repo initialized in the WORKSPACE. | ||
| "sed -e 's/ot_python_deps/ot_python_deps_vendored/g'", | ||
| # Change the labels from using the hub repo to using the spoke repos | ||
| # directly. | ||
| "sed -e 's|//\\([^:]*\\):pkg|_\\1//:pkg|g'", | ||
| "sed -e 's|//\\([^:]*\\):whl|_\\1//:whl|g'", | ||
| "sed -e 's|//\\([^:]*\\):data|_\\1//:data|g'", | ||
| # Change the convenience macros to use the same naming. | ||
| "sed -e 's|//{}:{}|_{}//:{}|g' >$@", | ||
| ]), |
There was a problem hiding this comment.
This is a cool way of building this pipeline while being able to intersperse comments.
FYI, I think you could do this with a single sed invocation if you wanted to:
sed \
-e 's|...|...|g' \
-e 's|...|...|g' \
-e 's|...|...|g' \
$< >$@
There was a problem hiding this comment.
Ah good idea. Let me update this in a follow up.
Our current version of rules_python autogenerates the `requirements.bzl` file from a `requirements.txt` lock file. However, this is awkward if this project is ever a dependency of another downstream bazel project, as shown here: bazelbuild/rules_python#608 To circumvent this issue, rules_python provides a mechanism to vendor in the requirements.bzl file into the repo, which this commit does. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
update-rules-python
branch
from
b2c2529 to
ea8620c
Compare
|
submitted as part of #26091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current version of rules_python autogenerates the
requirements.bzlfile from arequirements.txtlock file. However, this is awkward if this project is ever a dependency of another downstream bazel project, as shown here: bazelbuild/rules_python#608To circumvent this issue, rules_python provides a mechanism to vendor in the requirements.bzl file into the repo, which this commit does.
Additionally, this updates the
rules_pythonversion to match themasterbranch, and also updates thepython-requirements.txtlock file.This is part 1 of a series of changes that will re-enable airgapped builds with python dependencies.