[fusesoc] Move all cores under the hw directory #26142
Conversation
a-will
force-pushed
the
move-cores-root
branch
from
8cc42f3 to
88e0b7d
Compare
a-will
requested review from
hcallahan-lowrisc,
pamaury,
cfrantz,
vogelpi and
matutem
and removed request for
a team and
mundaym
| @@ -8,14 +8,14 @@ description: "Check tool requirements" | |||
| filesets: | |||
| files_check_tool_requirements: | |||
| files: | |||
| - util/check_tool_requirements.py : { copyto: util/check_tool_requirements.py } | |||
| - check_tool_requirements.py : { copyto: check_tool_requirements.py } | |||
There was a problem hiding this comment.
This seems weird, copyto yourself? I imagine this is the default fusesoc action if it refers to the name given under the per core subdirectory, so this copyto is unnecessary?
There was a problem hiding this comment.
Probably, but I'm not looking to clean up this core right now. There's a listed issue for this that doesn't appear to be closed ( olofk/fusesoc#353 ), and I'll let someone else figure that out. 😄
There was a problem hiding this comment.
Thanks for the PR @a-will . This solves a real issue (or a series of issues I believe) :-)
What is a bit unfortunate is that the tool_requirements file also has a requirement for Hugo in it, which doesn't seem right for a file in the hardware folder. But to be honest, I don't know if we still use that?
Maybe it would make sense to move the scripts into hw/util instead of just hw?
I think we don't. It seems the requirement for hugo was removed in #23989 Hugo is still referenced in
I'm not sure whether having this core is particularly useful, nor about whether a non-descript "util" sub-directory does much, haha. However, I can move the files. |
a-will
force-pushed
the
move-cores-root
branch
2 times, most recently
from
5c287c0 to
7c3b289
Compare
Avoid conflicts with various build output directories that get placed at the root of the repo, including bazel's symlinks, by placing fusesoc's cores-root in a subdirectory (specifically, the hw/ subdirectory). Move the check_tool_requirements core and scripts, plus the tool_requirements.py script, to the hw directory, so there is just the one cores-root for the opentitan repo. Signed-off-by: Alexander Williams <[email protected]>
a-will
force-pushed
the
move-cores-root
branch
from
7c3b289 to
34c7720
Compare
On second thought, I will skip this for now. The bazel fusesoc_build targets work in a really bizarre way, and the check_tool_requirements core is currently being used to represent --cores-root. I don't want to tackle this problem in this PR. 😅 |
Avoid conflicts with various build output directories that get placed at the root of the repo, including bazel's symlinks, by placing fusesoc's cores-root in a subdirectory (specifically, the hw/ subdirectory).
Move the check_tool_requirements core and scripts, plus the tool_requirements.py script, to the hw directory, so there is just the one cores-root for the opentitan repo.