Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hmac,dv] Directed test to cover FSM trans hole #26159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martin-velay
Copy link
Contributor

  • FSM transition StLenHi->StIdle is missing, a directed test is required. This test is waiting until this state is detected and disable SHA core (sha_en=0). This has the effect of moving the FSM back to StIdle state.

@martin-velay martin-velay self-assigned this Feb 6, 2025
@martin-velay martin-velay added Component:DV DV issue: testbench, test case, etc. IP:hmac labels Feb 6, 2025
- FSM transition StLenHi->StIdle is missing, a directed test is
required. This test waits until this state is detected and triggers
a reset. This has the effect of moving the FSM back to StIdle state.

Signed-off-by: Martin Velay <[email protected]>
@martin-velay
Copy link
Contributor Author

FYI: I have first tried to cover this transition by setting sha_en=0 at a proper moment, but this is not possible or at least really tough as changes on cfg register are ignored if a a stop command hasn't been seen before, only when cfg_block=0:

end else if (reg_hash_done || reg_hash_stop) begin

The register writes are effective in more or less time and the backdoor writes are not working as expected into account for some reason.
That's why, the reset solution has been applied.

@martin-velay martin-velay marked this pull request as ready for review February 7, 2025 15:25
@martin-velay martin-velay requested a review from a team as a code owner February 7, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant