[dice,cwt] Measure Owner SW domain in CDI 1 mode field #26498
+60
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasdf
force-pushed
the
mgT30747467
branch
4 times, most recently
from
5bee272 to
1bc5436
Compare
| cert_key_id_pair_t *key_ids, | ||
| ecdsa_p256_public_key_t *cdi_1_pubkey, | ||
| uint8_t *cert, size_t *cert_size) { | ||
| OT_DISCARD(key_domain); |
There was a problem hiding this comment.
Why discard? both X.509 and CWT should both set the the appropriate debug flag. For X.509, the cdi_0.hjson needs to be updated to match the uds.hjson (see here: https://cs.opensource.google/opentitan/opentitan/+/master:sw/device/silicon_creator/lib/cert/uds.hjson;drc=cce24966b1629b8f9a2ff22d6f44646f4c4857ca;l=121); the DiceTcbInfo extension has a flags field to put the debug mode; debug is 0 or 1 though, unlike CWT which looks like you use 1 or 2?
sasdf
force-pushed
the
mgT30747467
branch
2 times, most recently
from
e3bca5a to
8eef2d1
Compare
timothytrippel
approved these changes
Mar 6, 2025
Our current DICE chain has no field that can easily distinguish between device booting with prod and dev Owner SW signing keys, since it’s implicitly measured in the code hash. According to Open Profile for DICE, the mode field is the canonical way to identify prod/dev/etc, and it should be set to non-Normal if the device is not in a secure state. Change-Id: I307474674ababd3ca27dee696b5baf5f3e426b42 Signed-off-by: Yi-Hsuan Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current DICE chain has no field that can easily distinguish between device booting with prod and dev Owner SW signing keys, since it’s implicitly measured in the code hash. According to Open Profile for DICE, the "mode" field is the canonical way to identify prod/dev/etc, and it should be set to non-Normal if the device is not in a secure state.