[prim] Add mubix_logic_test_true_strict function #26500
Open
+72
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin-velay
commented
Mar 4, 2025
martin-velay
commented
- this function is similar to mubix_test_true_strict, but takes a logic as input instead of a mubix_t type.
|
@rswarbrick, FYI this PR should be merged before #26446 to avoid to break the master |
rswarbrick
reviewed
Mar 6, 2025
| // The strict version of this function requires | ||
| // the multibit value to equal True. | ||
| function automatic logic mubi${nbits}_logic_test_true_strict(logic [${nbits-1}:0] val); | ||
| return MuBi${nbits}True === mubi${nbits}_t'(val); |
There was a problem hiding this comment.
Are you sure you need this cast? I think SV will consider the enum value as a bit vector without it (which is what we want). It doesn't really matter, but this avoids casting a possibly-bogus bit vector to the enum type.
There was a problem hiding this comment.
I though I need it, but finally you're right I don't ! Thanks. I have pushed the change. BTW in case you haven't noticed I have preferred to check for a strict equivalence === just in case as the input is a logic.
- this function is similar to mubix_test_true_strict, but takes a logic as input instead of a mubix_t type. Signed-off-by: Martin Velay <[email protected]>
martin-velay
force-pushed
the
mubi_update
branch
from
dc325a1 to
2ce39b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.