-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Software fixes for Darjeeling DV #26504
Draft
pamaury
wants to merge
14
commits into
lowRISC:master
Choose a base branch
from
pamaury:dj_sw_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+221
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45b349b
to
9491808
Compare
Signed-off-by: Amaury Pouly <[email protected]>
Compile all DJ tests, not just the UART smoketest. Signed-off-by: Amaury Pouly <[email protected]>
The template was still using earlgrey types. This requires to pass top information to the generator and templates. Signed-off-by: Amaury Pouly <[email protected]>
On Darjeeling, the MMIO is not open by default, therefore the ePMP needs to be configured prior to doing any register access. Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
52d57f5
to
d5bb8e8
Compare
Signed-off-by: Adrian Lees <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
The RAM was temporarily put at the beginning of the CTN region to workaround the software using the wrong linking address. Signed-off-by: Amaury Pouly <[email protected]>
The test code is stored in a RAM inside the CTN space at a fixed offset. Signed-off-by: Amaury Pouly <[email protected]>
Instead of duplicating the logic to find the manifest, rely on the fact that the OTTF already needs to know the address to link. Therefore we can reuse the OTTF top config to create a symbol for the manifest address. Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
This higher-level function provides a convenient way to connect a peripheral I/O to a pad without needing to know if it's an MIO/DIO: it will do the natural thing in all cases. This is useful for multitop because Earlgrey and Darjeeling have different kinds of pads, e.g. the GPIOs are MIOs on EG but DIOs on DJ. Signed-off-by: Amaury Pouly <[email protected]>
Ideally part of this code should be moved to a top-specific library but in the mean time, provide a common solution for EG and DJ. Signed-off-by: Amaury Pouly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR recreates the SW fixes identified by @alees24 in #26088 in a way that is compatible with all tops. Not everything has been converted yet.