[pattgen,rtl] pattgen_chan cleanup #26520
Open
+50
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup these two related signals into seperate functional blocks, in preparation for an upcoming documentation commit. Signed-off-by: Harry Callahan <[email protected]>
This conditional is used thrice, so factor it out into a sensibly named signal. This will also gain a documentation comment in an upcoming commit. Signed-off-by: Harry Callahan <[email protected]>
hcallahan-lowrisc
force-pushed
the
pattgen_chan_cleanup
branch
from
2de5bf7 to
3262267
Compare
alees24
reviewed
Mar 6, 2025
Signed-off-by: Harry Callahan <[email protected]>
hcallahan-lowrisc
force-pushed
the
pattgen_chan_cleanup
branch
from
3262267 to
d53b20b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by reading the code while trying to review #26319 and interpret the vague testpoint description. This change clarifies the implementation of a pattgen channel to better match up with the spec documentation.
No functional change. The first two commits are minor RTL refactors, while the third extends the documentation comments throughout the new changes.
The documentation describes a FSM which does not exist in a canonical form within the module, but is practically implemented using the 'active' signal. Add a documentation comment to the code explaining this. I guess an alternative would be to change the RTL, but I wanted to keep the changes minimal for this changeset.